Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-15991

[VSSolution] Loads of "error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier"

    XMLWordPrintable

    Details

      Description

      Reproduce (like AppVeyor build) by executing:

      configure.cmd VSSolution
      msbuild /verbosity:quiet /target:bootcd REACTOS.sln
      

       

      It seems to affect .y and .l files only.

      This is a regression: guilty commit is 0.4.12-dev-1064-g09c4d0a.
      See detailed history in later comment.

      NB:

      • gcc, msvc and msvc-x64 are unaffected/fixed.
      • clang-cl has a related issue, again.

      cl : Command line warning D9025: overriding '/DREACTOS_SOURCE_DIR="c:/reactos-cov"' with '/UREACTOS_SOURCE_DIR' [C:\ros_build\dll\directx\wine\d3dcompiler_43\d3dcompiler_43.vcxproj]
      ...
      asmshader.y(318): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\dll\directx\wine\d3dcompiler_43\d3dcompiler_43.vcxproj]
      ...
      asmshader.l(469): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\dll\directx\wine\d3dcompiler_43\d3dcompiler_43.vcxproj]
      ...
      hlsl.y(85): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\dll\directx\wine\d3dcompiler_43\d3dcompiler_43.vcxproj]
      ...
      hlsl.l(225): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\dll\directx\wine\d3dcompiler_43\d3dcompiler_43.vcxproj]
      ...
      cl : Command line warning D9025: overriding '/DREACTOS_SOURCE_DIR="c:/reactos-cov"' with '/UREACTOS_SOURCE_DIR' [C:\ros_build\dll\win32\jscript\jscript.vcxproj]
      ...
      cc_parser.y(52): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\dll\win32\jscript\jscript.vcxproj]
      ...
      parser.y(789): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\dll\win32\jscript\jscript.vcxproj]
      ...
      cl : Command line warning D9025: overriding '/DREACTOS_SOURCE_DIR="c:/reactos-cov"' with '/UREACTOS_SOURCE_DIR' [C:\ros_build\dll\win32\msi\msi.vcxproj]
      ...
      sql.y(845): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\dll\win32\msi\msi.vcxproj]
      sql.y(1004): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\dll\win32\msi\msi.vcxproj]
      cond.y(494): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\dll\win32\msi\msi.vcxproj]
      ...
      cl : Command line warning D9025: overriding '/DREACTOS_SOURCE_DIR="c:/reactos-cov"' with '/UREACTOS_SOURCE_DIR' [C:\ros_build\dll\win32\msxml3\msxml3.vcxproj]
      ...
      xslpattern.y(47): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\dll\win32\msxml3\msxml3.vcxproj]
      ...
      xslpattern.l(116): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\dll\win32\msxml3\msxml3.vcxproj]
      ...
      cl : Command line warning D9025: overriding '/DREACTOS_SOURCE_DIR="c:/reactos-cov"' with '/UREACTOS_SOURCE_DIR' [C:\ros_build\dll\win32\vbscript\vbscript.vcxproj]
      ...
      parser.y(831): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\dll\win32\vbscript\vbscript.vcxproj]
      ...
      cl : Command line warning D9025: overriding '/DREACTOS_SOURCE_DIR="c:/reactos-cov"' with '/UREACTOS_SOURCE_DIR' [C:\ros_build\dll\win32\wbemprox\wbemprox.vcxproj]
      ...
      wql.y(99): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\dll\win32\wbemprox\wbemprox.vcxproj]
      ...
      cl : Command line warning D9025: overriding '/DREACTOS_SOURCE_DIR="c:/reactos-cov"' with '/UREACTOS_SOURCE_DIR' [C:\ros_build\base\applications\winhlp32\winhlp32.vcxproj]
      ...
      macro.lex.l(166): error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier [C:\ros_build\base\applications\winhlp32\winhlp32.vcxproj]
      ...
      

        Attachments

        1. 1_configure_VSSolution_ok.png
          50 kB
          reactosfanboy
        2. 3_unpatched__msbuild_fails_with_ERROR_Sourcedir.png
          67 kB
          reactosfanboy
        3. 6_patched__success_msbuild_bootcd.png
          59 kB
          reactosfanboy
        4. relfile.patch
          2 kB
          Katayama Hirofumi MZ
        5. relfile.patch
          2 kB
          Katayama Hirofumi MZ
        6. revertTest_2RunTheBots_On_0_4_14RC.patch
          4 kB
          reactosfanboy
        7. ROSBE2_1_6_GCC_4_7_2_DOES_NOT_WARN_IN_RELEASE_CONFIG_WITH_THE_HPOUSSIN_PATCH.txt
          12 kB
          reactosfanboy
        8. ROSBE2_1_6_GCC_4_7_2_WARNS_IN_RELEASE_CONFIG_ONLY_WITHOUT_THE_HPOUSSIN_PATCH.txt
          41 kB
          reactosfanboy
        9. yFiles.png
          12 kB
          reactosfanboy

          Issue Links

            Activity

              People

              • Assignee:
                reactosfanboy reactosfanboy
                Reporter:
                Serge Gautherie Serge Gautherie
              • Votes:
                5 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: