Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16400

Regression: Cyrillic text drawing regressed in Inno Setup 5.6.1 and Magma visual style

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.13
    • Component/s: None
    • Labels:
    • Environment:

      VirtualBox 5.1.38.

    • Module:
    • Guilty Commit:
      0.4.13-dev-1009-gca967db5ca65d289e3dc2ed05e5e1b49673ed3e5

      Description

      For reproducing the visual style bug,

      1. Install ReactOS with Russian localization by selecting it at 1st setup stage.
      2. Download Magma visual style here: http://stascorp.com/_ld/0/16_msstyle_magma.exe.
      3. Launch it.
      4. Extract it into %SystemRoot%\Resources\Themes by clicking Browse... (Обзор...), then specify a path and finally click Extract (Извлечь).
      5. Open Display Properties (Свойства: Экран).
      6. Go to Appearance (Оформление) tab.
      7. Select Magma Style from the Visual Style (Окна и кнопки) dropdown list.
      8. Click Apply (Применить) button at the right bottom.
      9. After applying the style, take a look on the titlebars of all windows which have cyrillic (Russian) text.

      In 0.4.13-dev-1008-ge85e396438f9cde018dbd7e4467571c0f1d53663 the text draws correctly.
      In 0.4.13-dev-1009-gca967db5ca65d289e3dc2ed05e5e1b49673ed3e5 you will see the rectangles instead of the text.

      Latin (English) text is not affected and is displayed correctly.

      For reproducing the Inno Setup bug,

      1. Install ReactOS same with Russian localization.
      2. Download Inno Setup 5.6.1 installer here: http://files.jrsoftware.org/is/5/innosetup-5.6.1.exe. It's non-unicode version, but unicode version is also affected.
      3. Launch the installer.
      4. Select Russian (Русский) language from the language selection dropdown list.
      5. Click Next (Далее), then accept the license by marking the I accept the agreement ckeckbox (Я принимаю условия соглашения).
      6. Pass other steps with default settings by clicking Next (Далее).
      7. Install it by cliking Install (Установить).
      8. Wait while it will be installed.
      9. After the installation, don't close the installer. Take a look on the title text at the top.

      In 0.4.13-dev-1008-ge85e396438f9cde018dbd7e4467571c0f1d53663 cyrillic text is also displayed correctly.
      In 0.4.13-dev-1009-gca967db5ca65d289e3dc2ed05e5e1b49673ed3e5 there are rectangles too.

      Latin text same is not affected.

      Btw, many other installers of third-party programs which use Inno Setup 5.6.1 and older, have the same bug.

      The font which Magma style uses in the window titlebars is Verdana. So looks like Inno Setup uses it too in its installers. And judging by the guilty commit, the problem is indeed caused by adding this font (its opensource equivalent) and deleting the previous font substitution.

        Attachments

          Activity

            People

            • Assignee:
              katayama_hirofumi_mz Katayama Hirofumi MZ
              Reporter:
              Oleg Dubinskij Oleg Dubinskiy
            • Votes:
              3 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: