Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17037

[class2.c] USB Storage driver with the old one works.

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • None
    • None
    • None

    Description

      As said at https://jira.reactos.org/browse/CORE-16511 , the USB Storage Driver doesn't work after the 8872007 commit.

      If we take the old (class2.c in "reactos/drivers/storage/class/class2/class2.c"), it works mostly similar as it did before the regression.

      I attach the log without the patch (usb-error):
      ReactOS 0.4.15-dev (Build 20200509-0.4.15-dev-194-gfc0a0b9)

       

      The same version with the edited file with the same compilation and no editing anymore files (usb-log-after):

       

      I don't know anything about developing, but this function is important for the real hardware testing, for the people that doesn't have modem for testing. If it doesn't cause any system breaks, and if Pierre is not able to fix it, we can do a temporary "class.c" get back. I attached the old one that I have added.

      Or the failed commit could be fixed or whatever.

      New update: It doesn't work perfectly well, I was wrong. The units appears duplicated. And if you extract the unit, the whole system freezes when you open any directory. I will attach the new update as usb-new-bug.log and a video.

       
      Surely  related to:

      CORE-16511, CORE-16486, CORE-16488

      Maybe related to:

      CORE-14493, CORE-14493, CORE-14037

      Three more lines about additional information:

      1. The SD have different behavior, because the drive is "always" shown (connected and disconnected), so it doesn't cause any freeze. Tried with a classic Samsung 4GB SD.
      2. The duplicity of the SD and USB ports only happens if they are mounted after the other Hard-drive disks.
      3. The format tool did ok BTRFS, FAT32 formats. Obviously, FAT32 slower than BTRFS.

      Attachments

        1. Bottest version.webm
          594 kB
          julenuri
        2. class2.c
          138 kB
          julenuri
        3. class2c replaced.webm
          825 kB
          julenuri
        4. usb-error.log
          76 kB
          julenuri
        5. usb-error-after.log
          77 kB
          julenuri
        6. usb-new-bug.log
          76 kB
          julenuri
        7. USB new bug.webm
          672 kB
          julenuri

        Issue Links

          Activity

            People

              Unassigned Unassigned
              julenuri julenuri
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: