[CORE-17351] Regression, [SHELL32] shlexec.cpp, RunDlg fails calling URL without http, because ShellExecCmdLine() rejects it to pass - ReactOS JIRA

XML

Word

Printable

Type: Bug
Status: Resolved
Priority: Minor
Resolution: Fixed
Fix Version/s: 0.4.7, 0.4.8, 0.4.9, 0.4.10, 0.4.11, 0.4.12, 0.4.13, 0.4.14, 0.4.15
Component/s: Shell
Labels:
- REGRESSION

Module:
- shell32
Guilty Commit:
0.4.10-dev-419-gbfcbda2 https://git.reactos.org/?p=reactos.git;a=commit;h=bfcbda227f99c1b59e8ed71f5e0f59f793d496a1

Reproduction steps

install Gecko during 2nd stage setup
use the RunDlg from startmenu, which passes its parameters into [SHELL32] shlexec.cpp ShellExecCmdLine()
type "www.google.de" without the quotes and without the preceeding http://

Expected result
Windows XP SP3 runs the default browser and displays the requested webpage

Observed result
On ros it displays a messagebox about the file not being found. That messagebox is generated by ShellExecCmdLine()
0.4.15-dev-1174-gde8d156_fails.webm
0.4.15-dev-1174-gde8d156_fails.log

P.S: I am aware that it would work as intended, if I had placed the http:// in front of it. But I did not, and it should still work.

blocks

CORE-6412 kernel32: rtl: shell32 FoxitReader4: starts directly instead of launching setup wizard (spaces in file name)

CORE-14790 Unable to execute "mspaint C:\a.bmp" from "Run" dialog

relates to

CORE-17612 [SHELL32] ShellExecCmdLine(), RunDlg does not accept calling a batch file without extension

CORE-16898 Run command "iexplore" fails to open Wine Internet Explorer

CORE-12664 Report for ShellExecute(Ex) bugs EPIC