Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17351

Regression, [SHELL32] shlexec.cpp, RunDlg fails calling URL without http, because ShellExecCmdLine() rejects it to pass

    XMLWordPrintable

    Details

      Description

      Reproduction steps

      • install Gecko during 2nd stage setup
      • use the RunDlg from startmenu, which passes its parameters into [SHELL32] shlexec.cpp ShellExecCmdLine()
      • type "www.google.de" without the quotes and without the preceeding http://

      Expected result
      Windows XP SP3 runs the default browser and displays the requested webpage

      Observed result
      On ros it displays a messagebox about the file not being found. That messagebox is generated by ShellExecCmdLine()
      0.4.15-dev-1174-gde8d156_fails.webm
      0.4.15-dev-1174-gde8d156_fails.log

      P.S: I am aware that it would work as intended, if I had placed the http:// in front of it. But I did not, and it should still work.

        Attachments

        1. 0.4.10-dev-418-gff63ef3_ok__does_pass_Firefox_Does_Open_That_URL.webm
          1.04 MB
          reactosfanboy
        2. 0.4.10-dev-419-gbfcbda2_failed__does_NOT_Pass_ShellExecCmdLine.webm
          481 kB
          reactosfanboy
        3. 0.4.15-dev-1174-gde8d156_fails.log
          76 kB
          reactosfanboy
        4. 0.4.15-dev-1174-gde8d156_fails.webm
          438 kB
          reactosfanboy
        5. api-monitor-api-filter.xml
          62 kB
          Katayama Hirofumi MZ
        6. api-monitor-api-filter.xml
          33 kB
          Katayama Hirofumi MZ
        7. do-exec-tests.bat
          0.1 kB
          Katayama Hirofumi MZ
        8. w2k3-api-monitor-google.txt
          371 kB
          Katayama Hirofumi MZ
        9. w2k3-api-monitor-google-without-https.txt
          194 kB
          Katayama Hirofumi MZ
        10. w2k3-api-monitor-hello.txt
          303 kB
          Katayama Hirofumi MZ
        11. w2k3-api-monitor-hello-bat.txt
          44 kB
          Katayama Hirofumi MZ
        12. w2k3-api-monitor-iexplore.txt
          451 kB
          Katayama Hirofumi MZ
        13. w2k3-api-monitor-notepad.txt
          367 kB
          Katayama Hirofumi MZ

          Issue Links

            Activity

              People

              • Assignee:
                DougLyons DougLyons
                Reporter:
                reactosfanboy reactosfanboy
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: