Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-19569

[NETCFGX] TCP/IP Filtering: missing keyboard navigation

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Trivial
    • 0.4.15
    • RosDlls
    • None

    Description

      reactos-bootcd-0.4.15-dev-8021-g7ce96fd-x86-gcc-lin-dbg

      • Open TCP/IP filtering properties
      • For none of the 3 group, keyboard navigation between Permit All and Permit Only work
      •  This is due to the same cause as CORE-19564 and CORE-19327
      • IDC_TCP_ALLOW_ALL, and IDC_TCP_RESTRICT all have the WS_GROUP, while only IDC_TCP_ALLOW_ALL should.
      • IDC_UDP_ALLOW_ALL, and IDC_UDP_RESTRICT all have the WS_GROUP, while only IDC_UDP_ALLOW_ALL should.
      • IDC_IP_ALLOW_ALL, and IDC_IP_RESTRICT all have the WS_GROUP, while only IDC_IP_ALLOW_ALL should.

      As explained in MSDN below (in particular all other controls in the group must have been consecutively created and must not have the WS_GROUP) : https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getnextdlggroupitem 

      The GetNextDlgGroupItem function searches controls in the order (or reverse order) they were created in the dialog box template. The first control in the group must have the WS_GROUP style; all other controls in the group must have been consecutively created and must not have the WS_GROUP style. 

      Patch (for en_US.rc, to be applied to all other .rc of this module)

      Attachments

        Issue Links

          Activity

            People

              MayTheChicken MayTheChicken
              KRosUser KRosUser
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: