Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 0.4.4
    • Component/s: Shell
    • Labels:

      Description

      This patch fixes some IShellLink bugs in shell32.

      ### shell32_winetest shelllink before patch ###
      shelllink.c:179: Test failed: GetPath failed (0x00000000)
      shelllink.c:199: Test failed: GetIDList failed (0x00000001)
      shelllink.c:242: Test failed: GetPath returned 'C:\nonexistent\file'
      shelllink.c:319: Test failed: GetIconLocation failed (0x80070002)
      shelllink.c:692: Test failed: GetPath returned 'C:\ReactOS\bin\shell32_winetest' instead of 'C:\ReactOS\bin\shell32_winetest.exe'
      shelllink.c:724: Test failed: GetPath returned 'C:\ReactOS\rundll32' instead of 'C:\ReactOS\system32\rundll32.exe'
      shelllink.c:803: Test failed: GetPath returned 'C:\Documents and Settings\Administrator\Local Settings\Temp\test' instead of 'C:\Documents and Settings\Administrator\Local Settings\Temp\test.bat'
      shelllink.c:963: Test failed: GetIconLocation failed (0x80070002)
      shelllink.c:977: Test failed: GetIconLocation failed (0x80070002)
      shelllink: 421 tests executed (0 marked as todo, 9 failures), 0 skipped.
       
      ### shell32_winetest shelllink after patch ###
      shelllink.c:206: Test failed: SHGetPathFromIDListA failed
      shelllink.c:319: Test failed: GetIconLocation failed (0x80004005)
      shelllink.c:963: Test failed: GetIconLocation failed (0x80004005)
      shelllink.c:977: Test failed: GetIconLocation failed (0x80004003)
      shelllink: 422 tests executed (0 marked as todo, 4 failures), 0 skipped.
      

      1. CShellLink-fix-retry.patch
        7 kB
        Katayama Hirofumi MZ
      2. shell32-fix-shelllink.patch
        5 kB
        Katayama Hirofumi MZ
      3. shelllink-after.log
        0.5 kB
        Katayama Hirofumi MZ
      4. shelllink-before.txt
        1 kB
        Katayama Hirofumi MZ

        Issue Links

          Activity

          Hide
          HBelusca
          added a comment -
          Show
          HBelusca
          added a comment - Cc Giannis Adamopoulos too.
          Hide
          Katayama Hirofumi MZ
          added a comment -

          I have tested it.
          C:\ReactOS\bin>shell32_winetest shelllink > E:\shelllink.log

          [BEFORE PATCH]
          shelllink: 437 tests executed (0 marked as todo, 9 failures), 2 skipped.
          [AFTER PATCH]
          shelllink: 437 tests executed (0 marked as todo, 4 failures), 2 skipped.

          Commit me.

          Show
          Katayama Hirofumi MZ
          added a comment - I have tested it. C:\ReactOS\bin>shell32_winetest shelllink > E:\shelllink.log [BEFORE PATCH] shelllink: 437 tests executed (0 marked as todo, 9 failures), 2 skipped. [AFTER PATCH] shelllink: 437 tests executed (0 marked as todo, 4 failures), 2 skipped. Commit me.
          Hide
          HBelusca
          added a comment -

          Temporarily assign the report to myself, for C/IShellLink::GetPath.

          Show
          HBelusca
          added a comment - Temporarily assign the report to myself, for C/IShellLink::GetPath.
          Hide
          HBelusca
          added a comment -

          Concerning the remark of SearchPathW and the hardcoded extensions, the correct way to go is to use shell32!PathResolve. Sadly it is currently unimplemented in ReactOS/Wine.

          Show
          HBelusca
          added a comment - Concerning the remark of SearchPathW and the hardcoded extensions, the correct way to go is to use shell32!PathResolve . Sadly it is currently unimplemented in ReactOS/Wine.
          Hide
          HBelusca
          added a comment -

          Fixed by r73576.

          Show
          HBelusca
          added a comment - Fixed by r73576.

            People

            • Assignee:
              HBelusca
              Reporter:
              Katayama Hirofumi MZ
            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: