Description
This patch fixes some IShellLink bugs in shell32.
### shell32_winetest shelllink before patch ###
|
shelllink.c:179: Test failed: GetPath failed (0x00000000)
|
shelllink.c:199: Test failed: GetIDList failed (0x00000001)
|
shelllink.c:242: Test failed: GetPath returned 'C:\nonexistent\file'
|
shelllink.c:319: Test failed: GetIconLocation failed (0x80070002)
|
shelllink.c:692: Test failed: GetPath returned 'C:\ReactOS\bin\shell32_winetest' instead of 'C:\ReactOS\bin\shell32_winetest.exe'
|
shelllink.c:724: Test failed: GetPath returned 'C:\ReactOS\rundll32' instead of 'C:\ReactOS\system32\rundll32.exe'
|
shelllink.c:803: Test failed: GetPath returned 'C:\Documents and Settings\Administrator\Local Settings\Temp\test' instead of 'C:\Documents and Settings\Administrator\Local Settings\Temp\test.bat'
|
shelllink.c:963: Test failed: GetIconLocation failed (0x80070002)
|
shelllink.c:977: Test failed: GetIconLocation failed (0x80070002)
|
shelllink: 421 tests executed (0 marked as todo, 9 failures), 0 skipped.
|
|
### shell32_winetest shelllink after patch ###
|
shelllink.c:206: Test failed: SHGetPathFromIDListA failed
|
shelllink.c:319: Test failed: GetIconLocation failed (0x80004005)
|
shelllink.c:963: Test failed: GetIconLocation failed (0x80004005)
|
shelllink.c:977: Test failed: GetIconLocation failed (0x80004003)
|
shelllink: 422 tests executed (0 marked as todo, 4 failures), 0 skipped.
|
Attachments
Issue Links
- is blocked by
-
CORE-12682 Fix/update CShellLink class
- Resolved
- relates to
-
CORE-9236 CShellLink: Support environment variables in shell links (shortcuts) target and icon
- Resolved
-
CORE-12665 shell32.dll needs PathResolve() implementation
- Resolved