Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-13722

[BROWSEUI] we waste 792kByte RAM additionally by just moving some resources around

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Trivial
    • Resolution: Unresolved
    • Fix Version/s: 0.4.13
    • Component/s: Shell
    • Labels:
    • Module:
    • Guilty Commit:
      0.4.7-dev-147-gc311042950521d1952d2bff301c7837c93c1af07
    • Guilty Revision:
      75,677

      Description

      Sorry for opening another one of these ressource-consumption-tickets, but this is really strange:

      I always measure RAM-usage in taskmgr right after 4th stage bootup (unrelated: with AC97):

      reactOS gcc dbg r75675: 107904 kByte
      reactOS gcc dbg r75677: 108696 kByte
      All we did in this commit was to move some bitmap resources from shell32 to browseui.

      Please note: I did not even start a filebrowser here where we use these resources of browseui. So at this moment I would have expected RAM-usage actually to maybe even decrease or stay constant, but not to increase by 792kByte.

      Does the replacement of GetModuleHandle() towards _AtlBaseModule.GetResourceInstance() play a role maybe in addressband.cpp and brandband.cpp?

      Yes, this is reproducible by switching between those revisions.

      Can we prevent that RAM usage increase?

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              reactosfanboy reactosfanboy
            • Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: