Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-13722

[BROWSEUI] we waste 792kByte RAM additionally by just moving some resources around

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Trivial
    • 0.4.15
    • Shell
    • 0.4.7-dev-147-gc311042950521d1952d2bff301c7837c93c1af07
    • 75,677

    Description

      Sorry for opening another one of these ressource-consumption-tickets, but this is really strange:

      I always measure RAM-usage in taskmgr right after 4th stage bootup (unrelated: with AC97):

      reactOS gcc dbg r75675: 107904 kByte
      reactOS gcc dbg r75677: 108696 kByte
      All we did in this commit was to move some bitmap resources from shell32 to browseui.

      Please note: I did not even start a filebrowser here where we use these resources of browseui. So at this moment I would have expected RAM-usage actually to maybe even decrease or stay constant, but not to increase by 792kByte.

      Does the replacement of GetModuleHandle() towards _AtlBaseModule.GetResourceInstance() play a role maybe in addressband.cpp and brandband.cpp?

      Yes, this is reproducible by switching between those revisions.

      Can we prevent that RAM usage increase?

      Attachments

        1. rundll32.exe.txt
          8 kB
        2. ReactOS-15-765_vs_75675.png
          ReactOS-15-765_vs_75675.png
          164 kB
        3. our-shell32.dll.txt
          53 kB
        4. ms-shell32.dll.txt
          94 kB
        5. explorer.exe.txt
          33 kB
        6. dump-zip-is-dangerous.png
          dump-zip-is-dangerous.png
          76 kB
        7. dump.zip
          6 kB
        8. DoNOTCommit-PatchDoesNotHelp.patch
          3 kB
        9. csrss.exe.txt
          5 kB
        10. browseui.dll.txt
          40 kB
        11. 4DllsExtractedFromOfficial_iso.reactos.org_bootcd_gcc_dbg_lin.zip
          5.01 MB

        Activity

          People

            Smiley Giannis Adamopoulos
            reactosfanboy reactosfanboy
            Votes:
            3 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: