Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16742

Start button background in themes is scaled incorrectly.

    XMLWordPrintable

Details

    Description

      This can easily be seen when applying a theme designed for Windows XP and comparing it to how it looks on an actual install of XP or any of its variants that has theme support (i.e. POSReady 2009), making the image too small vertically. I haven't looked at the source, but I suspect it's because the image is scaled to fit the taskbar height maybe when it's supposed to be absolute height? The image attached shows a bit of the start button from the Luna theme that is only supposed to be visible if the taskbar height is higher than default. The green area is supposed to fill the taskbar otherwise.

       

      Oh and as a side note, the start text should be all lowercase.

      Attachments

        1. reactos_start_bg_bug.png
          reactos_start_bg_bug.png
          8 kB
        2. 0.4.7-dev-704-gb10dd06.png
          0.4.7-dev-704-gb10dd06.png
          66 kB
        3. 0.4.7-dev-705-g85ae842.png
          0.4.7-dev-705-g85ae842.png
          66 kB
        4. revert-freetype.patch
          1 kB
        5. patched.png
          patched.png
          69 kB
        6. revert-PR2146.patch
          1 kB
        7. revert-PR1235.patch
          0.9 kB
        8. revert-PR745.patch
          1 kB
        9. valid-PR745-revert.png
          valid-PR745-revert.png
          23 kB
        10. WindowsXP.jpg
          WindowsXP.jpg
          22 kB
        11. XP-ReactOS-comparison.jpg
          XP-ReactOS-comparison.jpg
          5 kB
        12. bootcd-0.4.15-dev-272-g240f673.PNG
          bootcd-0.4.15-dev-272-g240f673.PNG
          34 kB
        13. bootcd_0.4.15-dev-272-g240f673.PNG
          bootcd_0.4.15-dev-272-g240f673.PNG
          40 kB
        14. start-button.patch
          0.4 kB
        15. explorer_patched.png
          explorer_patched.png
          32 kB
        16. start-button-theme-size-03.patch
          1 kB
        17. LunaXP_Start_New.png
          LunaXP_Start_New.png
          91 kB
        18. Zune_Start_New.png
          Zune_Start_New.png
          78 kB
        19. LunaROS_Start_New.png
          LunaROS_Start_New.png
          67 kB
        20. xpsp3_running_our_unpatched_explorer_is_not_affected.png
          xpsp3_running_our_unpatched_explorer_is_not_affected.png
          27 kB
        21. xpsp3_running_our_unpatched_explorer_is_not_affected.png
          xpsp3_running_our_unpatched_explorer_is_not_affected.png
          27 kB
        22. xpsp3_MSLuna_MSexplorer.webm
          272 kB
        23. xpsp3_MSLuna_ros_explorer_unpatched.webm
          291 kB
        24. xpsp3_MSLuna_ros_explorer_PR4121patched.webm
          468 kB
        25. xpsp3classic_MSexplorer.webm
          734 kB
        26. xpsp3classic_ros_explorer_PR4121patched.webm
          834 kB

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. CORE-12285 Reactos Theming Issues [Themes / Theme-ing / Themeing]

          • Major - Major loss of function.
          • Untriaged

          Improvement - An improvement or enhancement to an existing feature or task. CORE-13840 Font/FreeType: Fix the values of GetTextExtentPoint32 and GetTextMetrics

          • Major - Major loss of function.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. CORE-17832 Theme Windows 11 for XP (Aero 11) - The icon on the Start button is not displayed correctly

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CORE-14246 Theme - Windows Xp Style Wood - the "Start" button is longer than in Windows Xp

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Reopened

          Bug - A problem which impairs or prevents the functions of the product. CORE-14257 Theme - Aerotaskbar_xpstyle (Opus) - the "Start" button on the taskbar is not in its place

          • Major - Major loss of function.
          • Untriaged

          Improvement - An improvement or enhancement to an existing feature or task. CORE-16753 [USER32_APITEST] Strengthen DrawText testcase

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-12890 Broken Start button when applying third-party themes

          • Major - Major loss of function.
          • Untriaged

          Activity

            People

              DougLyons DougLyons
              Toru the Red Fox Toru the Red Fox
              Votes:
              6 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: