Core ReactOS
  1. Core ReactOS
  2. CORE-12229

[msi?] required disk-space negative in MSExcel Viewer2007 when ros setup german localization

    Details

    • Type: Bug Bug
    • Status: Untriaged Untriaged
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      r73036 is affected

      Microsoft Excel Viewer 2007 installer reports negative required disk space of "-789054976bytes".
      happens only if german localization is selected during ros setup, when english ros setup is selected it's fine.
      The results seem to be biased sporadically additionally, be careful when interpreting therefore the following test:
      CORE-12229-requiredSize-regressionTest.txt

      (IIRC using r73036 also "OpenOffice 5.1.5.2" required "0bytes", so I guess we have a structural issue here)

      Maybe a very hard to solve ticket...

      1. shlwapi_StrFormatByteSizeW_apitest.patch
        6 kB
        Doug Lyons
      2. shlwapi_StrFormatByteSizeW_apitest.patch
        6 kB
        Doug Lyons
      3. r73519-react-DebugChannelShell.log
        509 kB
        reactosfanboy
      4. r73036-BSOD-MSExcelViewer2007.log
        1.03 MB
        reactosfanboy
      5. MSI_Costing3.txt
        2 kB
        Doug Lyons
      6. MSI_Costing1.txt
        2 kB
        Doug Lyons
      7. MIS_Costing2.txt
        2 kB
        Doug Lyons
      8. dialog.c.patch
        0.8 kB
        Mark Jansen
      9. Debug02.txt
        2 kB
        Doug Lyons
      10. Debug01.txt
        2 kB
        Doug Lyons
      11. CORE-12229-requiredSize-regressionTest.txt
        2 kB
        reactosfanboy
      1. snapshot44.png
        73 kB
      2. r73519-Office2000setupIsAffectedAsWell.png
        44 kB
      3. r73036-requiredSizeNegativeWhenRosIsGerman.png
        37 kB
      4. r73036-BSOD-duringInstallationOf-MS-ExcelViewer2007.png
        53 kB
      5. ExcelViewerInstall73503.png
        139 kB
      6. ExcelViewerInstall73503_Fix1.png
        68 kB
      7. ExcelViewerInstall_WinXP_LimitedMem.png
        10 kB
      8. ExcelViewerInstall_WinXP_DriveF.png
        8 kB
      9. 2K3_SP2-worksPerfectly-ActiveShimView.png
        35 kB

        Issue Links

          Activity

          Hide
          Mark Jansen
          added a comment - - edited

          heh.

          It's locale dependent :/

          StrFormatByteSizeW.c:40: Test failed: Expected L"1.00 KB" got L"1,00 KB"
          StrFormatByteSizeW.c:41: Test failed: Expected L"1.00 MB" got L"1,00 MB"
          StrFormatByteSizeW.c:42: Test failed: Expected L"1.00 GB" got L"1,00 GB"
          StrFormatByteSizeW.c:43: Test failed: Expected L"1.75 GB" got L"1,75 GB"
          StrFormatByteSizeW.c:44: Test failed: Expected L"2.00 GB" got L"2,00 GB"
          StrFormatByteSizeW.c:45: Test failed: Expected L"4.00 GB" got L"4,00 GB"
          StrFormatByteSizeW.c:46: Test failed: Expected L"1.00 TB" got L"1,00 TB"
          StrFormatByteSizeW.c:47: Test failed: Expected L"1.00 PB" got L"1,00 PB"
          StrFormatByteSizeW.c:48: Test failed: Expected L"1.00 EB" got L"1,00 EB"
          StrFormatByteSizeW.c:49: Test failed: Expected L"2.00 EB" got L"2,00 EB"
          StrFormatByteSizeW.c:50: Test failed: Expected L"4.00 EB" got L"4,00 EB"
          StrFormatByteSizeW.c:51: Test failed: Expected L"7.99 EB" got L"7,99 EB"
          

          Show
          Mark Jansen
          added a comment - - edited heh. It's locale dependent :/ StrFormatByteSizeW.c:40: Test failed: Expected L"1.00 KB" got L"1,00 KB" StrFormatByteSizeW.c:41: Test failed: Expected L"1.00 MB" got L"1,00 MB" StrFormatByteSizeW.c:42: Test failed: Expected L"1.00 GB" got L"1,00 GB" StrFormatByteSizeW.c:43: Test failed: Expected L"1.75 GB" got L"1,75 GB" StrFormatByteSizeW.c:44: Test failed: Expected L"2.00 GB" got L"2,00 GB" StrFormatByteSizeW.c:45: Test failed: Expected L"4.00 GB" got L"4,00 GB" StrFormatByteSizeW.c:46: Test failed: Expected L"1.00 TB" got L"1,00 TB" StrFormatByteSizeW.c:47: Test failed: Expected L"1.00 PB" got L"1,00 PB" StrFormatByteSizeW.c:48: Test failed: Expected L"1.00 EB" got L"1,00 EB" StrFormatByteSizeW.c:49: Test failed: Expected L"2.00 EB" got L"2,00 EB" StrFormatByteSizeW.c:50: Test failed: Expected L"4.00 EB" got L"4,00 EB" StrFormatByteSizeW.c:51: Test failed: Expected L"7.99 EB" got L"7,99 EB"
          Hide
          Doug Lyons
          added a comment -

          New apitest. Maybe a hack. What do you think?

          Show
          Doug Lyons
          added a comment - New apitest. Maybe a hack. What do you think?
          Hide
          victor martinez calvo
          added a comment -

          Looks as a nice hack
          Btw, probably you should check the last two items in the array KB,EB,etc in lowercase(iirc there are languages which could be using one of the letters in lowercase iirc).

          Show
          victor martinez calvo
          added a comment - Looks as a nice hack Btw, probably you should check the last two items in the array KB,EB,etc in lowercase(iirc there are languages which could be using one of the letters in lowercase iirc).
          Hide
          Mark Jansen
          added a comment -

          Doug Lyons: I have created a new issue to discuss this: CORE-12661

          Show
          Mark Jansen
          added a comment - Doug Lyons : I have created a new issue to discuss this: CORE-12661
          Hide
          Doug Lyons
          added a comment -

          The three attached MSI_Costing files were created on ReactOS using the English locale with +shell and +msi tracing turning on, so I believe that this issue is not just a German localization problem. As previously noted, the negative numbers are coming from the MSI Install section which can be seen with these logs. I added additional TRACE statements to see which items were responsible. You can add up the individual numbers and they match the final totals. Also, I have noticed that if you do the install right after a fresh ReactOS install the numbers will almost always be smaller than doing the install later. This seems to point to the possibility that the costing algorithm is returning memory addresses instead of the actual values. The MSI installer provides very inconsistent results for the Bytes Required (costing). All of this appears to be Wine-synced code. Luckily this does not affect the ability of the installer to work.

          Show
          Doug Lyons
          added a comment - The three attached MSI_Costing files were created on ReactOS using the English locale with +shell and +msi tracing turning on, so I believe that this issue is not just a German localization problem. As previously noted, the negative numbers are coming from the MSI Install section which can be seen with these logs. I added additional TRACE statements to see which items were responsible. You can add up the individual numbers and they match the final totals. Also, I have noticed that if you do the install right after a fresh ReactOS install the numbers will almost always be smaller than doing the install later. This seems to point to the possibility that the costing algorithm is returning memory addresses instead of the actual values. The MSI installer provides very inconsistent results for the Bytes Required (costing). All of this appears to be Wine-synced code. Luckily this does not affect the ability of the installer to work.

            People

            • Assignee:
              Bug Zilla
              Reporter:
              reactosfanboy
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated: