Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-13950

Implement shell change notification correctly

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • Major
    • None
    • None
    • None

    Description

      CORE-13841 and CORE-11453 and more are suffering by failures of shell notification in SHChangeNotify function.

      My plan is:
      1. Create a detailed testcase for SHChangeNotify by using SHChangeNotifyRegister. We already have SHChangeNotify test in shell32_winetest, but that is not enough.
      2. Investigate why notification won't reach Explorer's side.

      Attachments

        1. gotcha.png
          gotcha.png
          50 kB
        2. SysNotifyLog-w2k3.zip
          53 kB
        3. SysNotifyHooker-bin.zip
          1.20 MB
        4. SHChangeWatch.zip
          32 kB
        5. SHChangeWatch.zip
          32 kB
        6. SHChangeWatch.zip
          32 kB
        7. SHChangeWatch.zip
          32 kB
        8. SHChangeWatch-Win2k3.png
          SHChangeWatch-Win2k3.png
          47 kB
        9. SHChangeWatch-WinXP.png
          SHChangeWatch-WinXP.png
          63 kB
        10. SHChangeWatch2.zip
          34 kB
        11. cant-receive-notification.png
          cant-receive-notification.png
          49 kB
        12. revert.patch
          14 kB
        13. revert.patch
          16 kB
        14. man-in-the-mirror.patch
          26 kB
        15. milky-way.patch
          34 kB
        16. gargoyle.patch
          35 kB
        17. orange-pie.patch
          44 kB
        18. log.txt
          31 kB
        19. ReadDirChange.zip
          36 kB
        20. ReadDirChange.zip
          36 kB
        21. ChangeWatch.zip
          54 kB
        22. TestAPC.zip
          30 kB
        23. TestAPC-Win10.png
          TestAPC-Win10.png
          9 kB
        24. TestAPC-Win2k3.png
          TestAPC-Win2k3.png
          22 kB
        25. TestAPC-WinXP.png
          TestAPC-WinXP.png
          29 kB
        26. TestAPC-ReactOS-g917bcbf.png
          TestAPC-ReactOS-g917bcbf.png
          30 kB
        27. TestAPC-ReactOS-ga98bebb.png
          TestAPC-ReactOS-ga98bebb.png
          31 kB
        28. TestAPC-ReactOS-ga98bebb.png
          TestAPC-ReactOS-ga98bebb.png
          31 kB
        29. TestAPC-ReactOS-ga98bebb_txt.zip
          143 kB
        30. no-change.png
          no-change.png
          45 kB
        31. SleepEx.patch
          2 kB
        32. TestAPC2.zip
          30 kB
        33. TestAPC2.zip
          30 kB
        34. TestAPC2-ReactOS-gb139bae.png
          TestAPC2-ReactOS-gb139bae.png
          31 kB
        35. DirWatchAPC.zip
          58 kB
        36. DirWatchAPC.zip
          60 kB
        37. DirWatchAPC.zip
          61 kB
        38. DirWatchAPC.zip
          62 kB
        39. TestAPCHack.zip
          59 kB
        40. debugging-log.txt
          244 kB
        41. ChangeExplorer.zip
          75 kB
        42. DirWatchMockup.zip
          95 kB
        43. DirWatchMockup.zip
          142 kB
        44. DirWatchMockup.zip
          101 kB
        45. CDirectoryList.zip
          2 kB
        46. CDirectoryList.zip
          2 kB

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. CORE-9277 Major unimplemented features of the shell

          • Major - Major loss of function.
          • Open
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. CORE-16941 Change Notifications won't reach from Recycle Bin

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. CORE-16960 [SHELL32] CDefView::LV_RenameItems must update name

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-18079 The test program PidlTest fails about CSIDL_FLAG_NO_ALIAS

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-19531 Regression: opening shared folders in My Computer takes too much time

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-19612 Explorer : "HEAP: Trying to free an invalid address" when Creating / Deleting / Renaming

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-19615 Change Notification doesn't work in My Documents

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-16974 Our QueueUserAPC is broken

          • Major - Major loss of function.
          • Untriaged

          Bug - A problem which impairs or prevents the functions of the product. CORE-17922 The UNC path folders cannot catch change notification

          • Major - Major loss of function.
          • Untriaged

          Bug - A problem which impairs or prevents the functions of the product. CORE-19582 Subst command should broadcast WM_DEVICECHANGE message

          • Major - Major loss of function.
          • Untriaged

          Bug - A problem which impairs or prevents the functions of the product. CORE-19630 The contents of New Folder in Desktop won't update its display

          • Major - Major loss of function.
          • Untriaged
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. CORE-18079 The test program PidlTest fails about CSIDL_FLAG_NO_ALIAS

          • Major - Major loss of function.
          • Resolved

          New Feature - A new feature of the product, which has yet to be developed. ROSTESTS-255 Add SHChangeNotify tests

          • Major - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CORE-16492 Drive for a newly conected USB drive does not automatically appear in already opened Explorer window

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. CORE-12336 Administrator\Desktop\Folders doesn't refresh automatically

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-12619 Explorer treeview don't show new folders

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-11473 "My Documents": I cannot see a new file created by Explorer

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          New Feature - A new feature of the product, which has yet to be developed. CORE-13841 Implement ejection of CD/DVD/USB

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. CORE-11453 The icon "Recycle Bin" does not change after deleting the file

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-18475 contents of the quicklaunch bar should be refreshed automatically when an app places its link in there

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. CORE-19033 The desktop icon of Adobe Reader 9.0 still needs an explicit pressing of F5 to make its desktop icon visible

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. CORE-10391 Shortcut do not appears on desktop after Firefox 28 installation

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-10714 Icon for new installed app does not appear on desktop

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-17839 Miranda IM, uninstalling the app does succeed, but we need to press F5 to make its desktop icon disappear

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-18486 Explorer shows folder than no longer exists (thanks to history) and is able to resurect them !

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Untriaged

          Activity

            People

              katayama_hirofumi_mz Katayama Hirofumi MZ
              katayama_hirofumi_mz Katayama Hirofumi MZ
              Votes:
              10 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated: