"Crash Fixers" Task Force: Fix all the crashes in rostests

please create individual tickets for each crash that you intend to fix, please do not link all of them against ROSTESTS-388 ! We do use this here just as an epic to group them together.

2023-09-09

The purpose of this issue is to fix the following 13 crashes:

• advpack:DelNode - ExceptionCode: c0000005 CORE-19172 #5692
• comdlg32:filedlg - Debug Assertion Failed!
• comdlg32:printdlg - ExceptionCode: c0000005 CORE-19173 #5689 most likely not optimal
• d3drm:d3drm - ExceptionCode: c0000005
• dsound:capture - ExceptionCode: c0000005
• dsound:duplex - ExceptionCode: c0000005
• mshtml:activex - ExceptionCode: c0000005
• mshtml:htmldoc - ExceptionCode: c0000005
• ntdll:exception - ExceptionCode: 80000003
• setupapi:devinst - ExceptionCode: c0000005
• shell32:progman_dde - ExceptionCode: c0000005
• urlmon:misc - ExceptionCode: c0000005
• ws2_32:sock - ExceptionCode: c0000005 ROSTESTS-385 #5609

The following tests are crashing on x64:

• advapi32:security
• compiler:pseh
• compiler:pseh_cpp
• kernel32:SetUnhandledExceptionFilter
• kmtest:NpfsReadWriten (randomly)
• mshtml:xmlhttprequest
• msi:action (randomly)
• msi:installn(randomly)
• msvcrt:cpp
• msvcrt:string (only after enabling NT6)
• netapi32:access
• ntdll:NtReadFile (randomly)
• ntdll:NtWriteFile (randomly)
• oleaut32:tmarshal
• oleaut32:vartest
• shell32:ShellExecCmdLine (randomly)
• shell32:ShellExecuteEx (randomly)
• shell32:ShellExecuteW (randomly)
• shlwapi:SHPropertyBag
• shlwapi:url
• wininet:ftp (Randomly. After enabling NT6?)
• wshom:wshom (Randomly. After enabling NT6?)

Step 1: Get a detailed log with the call stack (filenames and line numbers) (using the environment variable DEBUGCHANNEL).
Step 2: Detect the crash location (source filename and line number).
Step 3: Fix all crash causes in target components and/or rostests.